Skip to content

Remove import sys in logging documentation example #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

JohnPaton
Copy link
Contributor

The import of sys isn't necessary in the logging example, as sys.stdout is the default stream for StreamHandler. In the interest of keeping examples as minimal as possible I would suggest to remove references to sys.stdout and leave that to the logging documentation.

@max-sixty
Copy link
Contributor

Nice, thanks for the PR @JohnPaton , cleaner is better!

@max-sixty max-sixty merged commit d06db4b into googleapis:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants