Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Fix mandatory parameters and add textinput example #191

Merged
merged 3 commits into from
Feb 23, 2018

Conversation

lcaggio
Copy link

@lcaggio lcaggio commented Feb 23, 2018

Fix mandatory parameters (device-model-id, client-type) and add textinput example

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

python -m pushtotalk --device-id 'my-device-identifier' -o out.wav
python -m pushtotalk --device-id 'my-device-identifier' --device-model-id 'my-model-identifier' -o out.wav

- Send a text request to the Assistant::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/a text request/text requests/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits

@proppy proppy merged commit 96a583e into googlesamples:master Feb 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants