chore: prevent panics on invalid state input #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinor
force-pushed
the
chore/chat_state_checks
branch
4 times, most recently
from
3440dc0 to
fe29015
Compare
rinor
force-pushed
the
chore/chat_state_checks
branch
from
fe29015 to
bd27bb5
Compare
|
Did you hit a situation where you actually got a panic? I'm fine with this change, just curious if there's a bug elsewhere we need to fix. |
ibuildthecloud
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added just enough checks to prevent some panics on invalid chat state inputs encountered while investigating #311