fix: tool names should be used instead of filename #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/types/toolname.go
Outdated
| @@ -14,7 +14,8 @@ var ( | |||
| ) | |||
|
|
|||
| func ToolNormalizer(tool string) string { | |||
| parts := strings.Split(tool, "/") | |||
| fromParts := strings.Split(tool, "from") | |||
There was a problem hiding this comment.
There a method SplitToolRef for this
There was a problem hiding this comment.
It will make the code a bit more complicated, but it will be more correct.
cloudnautique
force-pushed
the
use_tool_from_name
branch
3 times, most recently
from
d6efbbc to
a5843ae
Compare
rinor
reviewed
May 11, 2024
| @@ -14,7 +15,8 @@ var ( | |||
| ) | |||
|
|
|||
| func ToolNormalizer(tool string) string { | |||
| parts := strings.Split(tool, "/") | |||
| _, subTool := SplitToolRef(tool) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cloudnautique
force-pushed
the
use_tool_from_name
branch
from
a5843ae to
82d3207
Compare
Uses the toolname before the from otherwise it was using the filename and appending numbers losing context. Signed-off-by: Bill Maxwell <[email protected]>
cloudnautique
force-pushed
the
use_tool_from_name
branch
from
82d3207 to
a3219cb
Compare
ibuildthecloud
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the toolname before the from otherwise it was using the filename and appending numbers losing context.