feat: add a new SDK server #387
Conversation
thedadams
force-pushed
the
add-clicky-server
branch
2 times, most recently
from
734bdea to
f388182
Compare
thedadams
requested review from
ibuildthecloud,
njhale,
iwilltry42,
tylerslaton and
g-linville
thedadams
force-pushed
the
add-clicky-server
branch
4 times, most recently
from
b8aca50 to
3b3eefa
Compare
pkg/sdkserver/routes.go
Outdated
| if body[len(body)-1] != '}' { | ||
| body = append(body, '"', '}') | ||
| } |
There was a problem hiding this comment.
Is this in case a model making calls through the SDK fails to finish a JSON string?
There was a problem hiding this comment.
This was supposed to be removed, and I removed it from the wrong branch.
pkg/sdkserver/server.go
Outdated
| s := &server{ | ||
| client: g, | ||
| events: events, | ||
| } | ||
| defer s.Close() | ||
|
|
||
| s.addRoutes(http.DefaultServeMux) |
There was a problem hiding this comment.
Where does this s server end up getting used?
There was a problem hiding this comment.
In addRoutes, it sets up the routes for the various commands, which is where the client and events get used.
|
|
||
| instructions := strings.TrimPrefix(tool.Instructions, types.DaemonPrefix) | ||
| instructions, path := getPath(instructions) | ||
| tool.Instructions = types.CommandPrefix + instructions | ||
|
|
||
| port, ok := e.Ports.daemonPorts[tool.ID] | ||
| port, ok := ports.daemonPorts[tool.ID] | ||
| url := fmt.Sprintf("http://127.0.0.1:%d%s", port, path) |
There was a problem hiding this comment.
Not sure if there would be any use for this (and it's not part of your PR anyway), but can this be made configurable to listen on other interfaces as well?
There was a problem hiding this comment.
We can definitely discuss that!
thedadams
force-pushed
the
add-clicky-server
branch
from
3b3eefa to
24a294a
Compare
| return | ||
| } | ||
|
|
||
| logger.Debugf("parsing file: file=%s, content=%s", reqObject.File, reqObject.Content) |
There was a problem hiding this comment.
to log with fields or not to log with fields? 😁
This server will be used in the SDKs for running gptscripts. This change also includes an implementation that allows the SDKs to "confirm" tools execution. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
add-clicky-server
branch
from
24a294a to
0a75894
Compare
This server will be used in the SDKs for running gptscripts.