fix: ensure fd monitor file is closed at end of the script run #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running gptscript with providers and --events-stream-to flag, the file passed to --events-stream-to would be closed after the provider was setup. This is an error because the file should remain open for the duration of the script run. This change will ensure that the file is only closed when the script is complete. Additionally, this change introduces 0644 permissions when creating a file passed to --events-stream-to. Signed-off-by: Donnie Adams <[email protected]>
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
StrongMonkey
approved these changes
May 28, 2024
g-linville
approved these changes
May 28, 2024
njhale
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running gptscript with providers and --events-stream-to flag, the file passed to --events-stream-to would be closed after the provider was setup. This is an error because the file should remain open for the duration of the script run.
This change will ensure that the file is only closed when the script is complete.
Additionally, this change introduces 0644 permissions when creating a file passed to --events-stream-to.