Move DirectiveBehavior out of graphql.schema.idl package #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Java 11 module error
oliemansm
approved these changes
Feb 19, 2020
|
Another option would be to copy-paste the code from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282
This is super hacky but unfortunately the only way that lets us reuse the directive wiring logic from
graphql-java. Since the inner DTO classParametersis still package-private and we have to pass an instance of theParametersinto the helper we must resort to reflection.Since this only happens during start up I am not worried about performance. However, we must keep an eye on this class since breaking changes won't be caught by the compiler.