Skip to content

Build int and float default values correctly #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2021
Merged

Build int and float default values correctly #472

merged 2 commits into from
Jan 7, 2021

Conversation

oryan-block
Copy link
Collaborator

Fixes #344

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

Map IntValue and FloatValue to int and double respectively instead of BigInteger and BigDecimal

@oryan-block oryan-block requested a review from vojtapol January 7, 2021 17:25
@oryan-block oryan-block merged commit 69e2f3d into master Jan 7, 2021
@oryan-block oryan-block deleted the bugfix/344 branch January 7, 2021 18:24
@oryan-block oryan-block mentioned this pull request Mar 5, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtapol vojtapol vojtapol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default values specified for Int field are passed in as BigInteger to Resolver
2 participants
@oryan-block @vojtapol