This repository was archived by the owner on Dec 19, 2023. It is now read-only.
SchemaParserOptions.Builder Beans #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t be coerced using application properties so that one does not need to override the build entirely to add to the schema parser options
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to specify SchemaParserOptions.Builder options that can't be coerced using application properties so that one does not need to override the build entirely to add to the schema parser options.
Recently, a change was made such that the SchemaParserOptions usage was removed and a builder bean was added to GraphQLJavaToolsAutoConfiguration. A
@ConfigurationPropertieswas added to the bean so that the options can be set easily via the application properties. However, for those properties that can't be coerced from a simple type in the application properties, there is no other way to specify said options unless one overrides the builder bean entirely. This PR adds detection of beans that can be used in the SchemaParserOptions.Builder class such that one no longer needs to completely override the builder bean in order to specify these options, thus allowing all defaults to remain intact even after library updates (at least, without manually updating the code of the library client).