Skip to content

Correctly set minimal versions for graphql_client #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

DanielVoogsgerd
Copy link
Contributor

@DanielVoogsgerd DanielVoogsgerd commented May 29, 2025

Currently, the minimal version for serde_json is set incorrectly, it requires Eq to be implemented for serde_json::Value, yet this was only introduced in 1.0.50. Also removed a redundant caret in the serde dependency.

One other small consideration might be necessary for reqwest. Currently, the reqwest version is bound by >=0.11, <=0.12.
This seems odd, as in theory this would allow all of 0.11.x, but also 0.12.y. A quick test shows that Cargo refuses to select 0.12.y in this case. I am not sure if this is a bug in Cargo as well.

But to get back to this crate. If the idea is that everything in 0.11.x would be okay, but not 0.12.y the canonical way of defining this would be just 0.11.0 (or 0.11 if you want to be implicit). If 0.12.y should be selected too, I would just like to inform you that this seems to be currently unsupported by Cargo.

Never mind that last part, I was looking at 0.14 instead of main, my bad. I still think that >=0.11.0, <0.13.0 would be clearer, but that is simply preference.

@tomhoule
Copy link
Member

tomhoule commented Jun 3, 2025

Good call. I think we'll refocus the crate on just codegen, then the number of dependencies will be much lower.

@tomhoule tomhoule merged commit 46791c8 into graphql-rust:main Jun 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants