Correctly set minimal versions for graphql_client #541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the minimal version for serde_json is set incorrectly, it requires
Eq
to be implemented forserde_json::Value
, yet this was only introduced in 1.0.50. Also removed a redundant caret in the serde dependency.One other small consideration might be necessary for reqwest. Currently, the reqwest version is bound by
>=0.11, <=0.12
.This seems odd, as in theory this would allow all of0.11.x
, but also0.12.y
. A quick test shows that Cargo refuses to select0.12.y
in this case. I am not sure if this is a bug in Cargo as well.But to get back to this crate. If the idea is that everything in0.11.x
would be okay, but not0.12.y
the canonical way of defining this would be just0.11.0
(or0.11
if you want to be implicit). If0.12.y
should be selected too, I would just like to inform you that this seems to be currently unsupported by Cargo.Never mind that last part, I was looking at 0.14 instead of main, my bad. I still think that
>=0.11.0, <0.13.0
would be clearer, but that is simply preference.