Merge pull request #728 from APIs-guru/uniq_interfaces

Forbid object to declare that it implements same interface twice.

Author: leebyron

src/type/__tests__/validation-test.js

@@ -559,6 +559,30 @@ describe('Type System: Object interfaces must be array', () => {
     );
   });
 
+  it('rejects an Object that declare it implements same interface more than once', () => {
+    expect(() => {
+      const NonUniqInterface = new GraphQLInterfaceType({
+        name: 'NonUniqInterface',
+        resolveType: () => null,
+        fields: { f: { type: GraphQLString } },
+      });
+
+      const AnotherInterface = new GraphQLInterfaceType({
+        name: 'AnotherInterface',
+        resolveType: () => null,
+        fields: { f: { type: GraphQLString } },
+      });
+
+      schemaWithFieldType(new GraphQLObjectType({
+        name: 'SomeObject',
+        interfaces: () => [ NonUniqInterface, AnotherInterface, NonUniqInterface ],
+        fields: { f: { type: GraphQLString } }
+      }));
+    }).to.throw(
+      'SomeObject may declare it implements NonUniqInterface only once.'
+    );
+  });
+
   it('rejects an Object type with interfaces as a function returning an incorrect type', () => {
     expect(
       () => schemaWithFieldType(new GraphQLObjectType({

src/type/definition.js

@@ -449,12 +449,19 @@ function defineInterfaces(
     `${type.name} interfaces must be an Array or a function which returns ` +
     'an Array.'
   );
+
+  const implementedTypeNames = {};
   interfaces.forEach(iface => {
     invariant(
       iface instanceof GraphQLInterfaceType,
       `${type.name} may only implement Interface types, it cannot ` +
       `implement: ${String(iface)}.`
     );
+    invariant(
+      !implementedTypeNames[iface.name],
+      `${type.name} may declare it implements ${iface.name} only once.`
+    );
+    implementedTypeNames[iface.name] = true;
     if (typeof iface.resolveType !== 'function') {
       invariant(
         typeof type.isTypeOf === 'function',