Unify optional callbacks validation #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
force-pushed
the
isMaybeFunction
branch
from
8b179d3 to
8c8be29
Compare
IvanGoncharov
force-pushed
the
isMaybeFunction
branch
from
8c8be29 to
85d98f3
Compare
IvanGoncharov
force-pushed
the
isMaybeFunction
branch
from
85d98f3 to
84836af
Compare
mjmahone
approved these changes
Jul 29, 2018
| @@ -757,11 +756,6 @@ function isPlainObj(obj) { | |||
| return obj && typeof obj === 'object' && !Array.isArray(obj); | |||
| } | |||
|
|
|||
| // If a resolver is defined, it must be a function. | |||
| function isValidResolver(resolver: mixed): boolean { | |||
There was a problem hiding this comment.
Should we keep isValidResolver? I'm not totally sure what the advantage of inlining it is
There was a problem hiding this comment.
One reason would be that you can't share it without changing the name since isTypeOf not a resolver. Plus it also confusing since null and undefined are not valid resolvers but an explicit absence of resolver.
So the best name that I come up is isOptionalFunction which is the same as to just write resolver == null || typeof resolver === 'function'.
I think it's better to stay explicit.
There was a problem hiding this comment.
That's a reasonable argument. I'm convinced.
| ); | ||
| } | ||
| invariant( | ||
| config.resolveType == null || typeof config.resolveType === 'function', |
There was a problem hiding this comment.
All of these could now become isValidResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.