Update deps + switch to fixed versions in package.json #1418
Conversation
| "@babel/preset-env": "^7.0.0-beta.51", | ||
| "@babel/register": "^7.0.0-beta.51", | ||
| "babel-eslint": "8.2.4", | ||
| "@babel/cli": "7.0.0-beta.53", |
There was a problem hiding this comment.
Even though we use yarn I think it's better to use explicit versions in package.json.
There was a problem hiding this comment.
For devDependencies you're probably right. That's definitely not true for regular dependencies, as it can cause people to needlessly download multiple compatible versions of the same library.
There was a problem hiding this comment.
@mjmahone Plus I'm especially paranoid after eslint recent catastrophe and it motivated this change.
| "@babel/preset-env": "^7.0.0-beta.51", | ||
| "@babel/register": "^7.0.0-beta.51", | ||
| "babel-eslint": "8.2.4", | ||
| "@babel/cli": "7.0.0-beta.53", |
There was a problem hiding this comment.
For devDependencies you're probably right. That's definitely not true for regular dependencies, as it can cause people to needlessly download multiple compatible versions of the same library.
| @@ -48,34 +48,34 @@ | |||
| "iterall": "^1.2.2" | |||
There was a problem hiding this comment.
That's definitely not true for regular dependencies, as it can cause people to needlessly download multiple compatible versions of the same library.
@mjmahone Agree, iterall is the only one non-dev dependency we have and it's not pinned.
No description provided.