Disable eslint rules that can conflict with prettier #1421
Conversation
Continuation of 40f73fd Rules was disabled using this tool: https://github.com/prettier/eslint-config-prettier#cli-helper-tool
| "flowtype/space-before-type-colon": [2, "never"], | ||
| "flowtype/space-before-generic-bracket": [2, "never"], | ||
| "flowtype/union-intersection-spacing": [2, "always"], | ||
| "flowtype/space-after-type-colon": 0, |
There was a problem hiding this comment.
Do we get the same result if we just remove these lines completely? If so, it makes it a lot easier to parse the file, so let's delete them all.
If instead they default to 1, then yeah this is the way to go.
There was a problem hiding this comment.
@mjmahone It's useful to keep them as the reference for adding new rules.
I plan to add a bunch of new rules added in the past couple years and without having explicitly disabled ones it will make this task very hard.
Ideally, we need to check for new rules on every eslint update so I think we need to keep zeros.
And this was done previously for other rules: 40f73fd
I plan to cleanup eslint config more in a separate PR and swith to off, warn and error instead of 0,1 and 2.
There was a problem hiding this comment.
Sounds good! Thanks for the context.
Continuation of 40f73fd
Rules was disabled using this tool:
https://github.com/prettier/eslint-config-prettier#cli-helper-tool