Skip to content

Add missing 'type' prefixes to imports #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2018
Merged

Add missing 'type' prefixes to imports #1431

merged 1 commit into from
Jul 25, 2018

Conversation

IvanGoncharov
Copy link
Member

Missing type prefix results in unused imports in generated code, e.g.:

graphql-js/validation/validate.mjs

Line 12 in 6ca4079

import { GraphQLSchema } from '../type/schema';

@IvanGoncharov IvanGoncharov merged commit 6b95e50 into graphql:master Jul 25, 2018
@IvanGoncharov IvanGoncharov deleted the addMissingTypeToImport branch August 6, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgcmarins jgcmarins jgcmarins approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanGoncharov @jgcmarins @facebook-github-bot