Add unit tests for isRequired predicates #1486
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
src/type/__tests__/predicate-test.js
Outdated
| type: GraphQLString, | ||
| }; | ||
| expect(isRequiredArgument(optArg1)).to.equal(false); | ||
| const optArg2 = { |
There was a problem hiding this comment.
nit: maybe add an empty line here to improve readability
|
Ok, added some empty lines. |
|
This looks great! Thanks for adding the test. |
The two new predicates isRequiredArgument and isRequiredInputField did not yet have unit tests.