Convert error to warning for non-compliant use of __ #692
Conversation
This unbreaks various uses of graphql-js which were defining fields with __ while retaining some form of reporting warning for non-compliant use. Fixes #690
| if (!isIntrospection && name.slice(0, 2) === '__' && !hasWarnedAboutDunder) { | ||
| hasWarnedAboutDunder = true; | ||
| /* eslint-disable no-console */ | ||
| if (console && console.error) { |
There was a problem hiding this comment.
When would console ever be defined but falsey? Just being paranoid?
There was a problem hiding this comment.
Just being paranoid. I'd rather not have a cascading failure because someone's running graphql-js in some environment that either has no console or has console but doesn't have console.error.
There was a problem hiding this comment.
Would typeof console !== 'undefined' be even more robust then?
There was a problem hiding this comment.
I don't know what environment might have console set to null or false or something silly like that, but I think this check should robust against whatever value console might have.
Technically typeof console === 'object' would be more specific, but it wouldn't yield a different result
| ''; | ||
| console.error( | ||
| `GraphQL: Name "${name}" must not begin with "__", which is ` + | ||
| 'reserved by GraphQL introspection.' + stackOnly |
There was a problem hiding this comment.
"reserved for" better than "reserved by"?
| const prevConsoleError = console.error; | ||
| const calls = []; | ||
| console.error = function () { | ||
| calls.push(Array.prototype.slice.call(arguments)); |
There was a problem hiding this comment.
calls.push(Array.from(arguments));
Probably works in this environment too.
This unbreaks various uses of graphql-js which were defining fields with __ while retaining some form of reporting warning for non-compliant use.
Fixes #690