Skip to content

fix: Connection config nodetype #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Connection config nodetype #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/connection/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from 'graphql';

import type {
GraphQLNamedType,
GraphQLOutputType,
GraphQLFieldConfigArgumentMap,
GraphQLFieldConfigMap,
GraphQLFieldResolver,
Expand Down Expand Up @@ -75,7 +75,7 @@ export type ConnectionArguments = {

type ConnectionConfig = {
name?: string,
nodeType: GraphQLNamedType | GraphQLNonNull<GraphQLNamedType>,
nodeType: GraphQLOutputType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@saihaj Output types include arrays :( so we can't use it
How about you add GraphQLInputNamedType and GraphQLOutputNamedType to graphql-js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was merged and released to 16.x.x alpha channel graphql/graphql-js#3063 as we discussed on Slack I will update to use alpha for main and then I can rebase this branch

resolveNode?: GraphQLFieldResolver<any, any>,
resolveCursor?: GraphQLFieldResolver<any, any>,
edgeFields?: Thunk<GraphQLFieldConfigMap<any, any>>,
Expand Down