Skip to content

[InputUnion RFC]Add "readable error message" criteria #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged

[InputUnion RFC]Add "readable error message" criteria #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions rfcs/InputUnion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,14 @@ Adding an input to one or more unions should not require extraneous changes, con

Criteria score: 🥇

## 🎯 P. Validation rule should produce easy to understand error message

Implementation of validation rules should be able to produce easy to understand error for value that is invalid according to definition of input union. It's critical for developer experience since GrahphiQL, IDE and other similar tools will output this error during development.

| [1][solution-1] | [2][solution-2] | [3][solution-3] | [4][solution-4] | [5][solution-5] |
|----|----|----|----|----|
| ✅️ | ✅️ | 🚫 | 🚫 | ✅ |

# 🚧 Possible Solutions

The community has imagined a variety of possible solutions, synthesized here.
Expand Down