Skip to content

to build kts #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2020
Merged

to build kts #120

merged 2 commits into from
Jun 30, 2020

Conversation

jamesward
Copy link
Collaborator

Fixes #99

@chalin
Copy link
Contributor

chalin commented Jun 26, 2020

I think that this PR needs to be rebased -- since it currently shows Travis failures, but as far as I know we don't use Travis anymore :).

@jamesward
Copy link
Collaborator Author

Cool. Rebased.

@bshaffer
Copy link
Contributor

The tests are failing on a whole bunch of style rules. See here

@jamesward
Copy link
Collaborator Author

Fixed

@chalin chalin requested a review from bshaffer June 30, 2020 19:18
@chalin
Copy link
Contributor

chalin commented Jun 30, 2020

Anything more to be done here @bshaffer?

@bshaffer bshaffer merged commit 5bb4b1e into grpc:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example with build.gradle.kts configuration
3 participants