Skip to content

Add Android example #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Add Android example #137

merged 1 commit into from
Jul 8, 2020

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 30, 2020

This is a (temporary?) step towards addressing #131; see that issue for a discussion.

The content of this PR is essentially @jamesward's sample from GoogleCloudPlatform/kotlin-samples#67 placed under /examples-android, which has the following main top-level folders:

  • android
  • common - for the hello_world.proto file
  • server

Of course, I'd rather not have two example folders, but I didn't want to reorganize examples until I got some feedback from the team.

@chalin chalin requested a review from jamesward June 30, 2020 20:20
@chalin
Copy link
Contributor Author

chalin commented Jun 30, 2020

Closes #131
We'll use #138 as a followup

@jamesward jamesward merged commit ef5c808 into master Jul 8, 2020
@jamesward jamesward deleted the chalin-add-android-example-200630 branch July 8, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants