Lock ServerCall in ServerCalls re: #151 #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text elements." This reverts commit 989f1f1.
…CoroutineContext of the server.
…erformance (everything should be sequential anyway) but protects against thread safety issues.
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Aug 18, 2020
Motivation: `CoroutineContextServerInterceptor` is newly introduced in gRPC-Kotlin [0.1.5](https://github.com/grpc/grpc-kotlin/releases/tag/v0.1.5). Armeria gRPC server can inject the current `RequestContext` to Coroutine Context using it. The issue that `inHalfClose` unexpectly calls `ServerCall.close()` seems resolved by grpc/grpc-kotlin#157. I cannot reproduce it anymore. Modifications: - Add `ArmeriaCoroutineContextInterceptor` that is working only for gRPC-Kotlin stub. - Remove `inHalfClose` flag in ArmeriaServerCall Results: - You can now get the current `RequestContext` from the Coroutine Context of gRPC-Kotlin by default.
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Aug 18, 2020
Motivation: `CoroutineContextServerInterceptor` is newly introduced in gRPC-Kotlin [0.1.5](https://github.com/grpc/grpc-kotlin/releases/tag/v0.1.5). Armeria gRPC server can inject the current `RequestContext` to Coroutine Context using it. The issue that `inHalfClose` unexpectly calls `ServerCall.close()` seems resolved by grpc/grpc-kotlin#157. I cannot reproduce it anymore. Modifications: - Add `ArmeriaCoroutineContextInterceptor` that is working only for gRPC-Kotlin stub. - Remove `inHalfClose` flag in ArmeriaServerCall Results: - You can now get the current `RequestContext` from the Coroutine Context of gRPC-Kotlin by default.
trustin
pushed a commit
to line/armeria
that referenced
this pull request
Aug 19, 2020
Motivation: `CoroutineContextServerInterceptor` is newly introduced in gRPC-Kotlin [0.1.5](https://github.com/grpc/grpc-kotlin/releases/tag/v0.1.5). Armeria gRPC server can inject the current `RequestContext` to Coroutine Context using it. The issue that `inHalfClose` unexpectly calls `ServerCall.close()` seems resolved by grpc/grpc-kotlin#157. I cannot reproduce it anymore. Modifications: - Add `ArmeriaCoroutineContextInterceptor` that is working only for gRPC-Kotlin stub. - Remove `inHalfClose` flag in ArmeriaServerCall Results: - You can now get the current `RequestContext` from the Coroutine Context of gRPC-Kotlin by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.