Skip to content

Support for GstMeta (partial) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 20, 2020
Merged

Support for GstMeta (partial) #208

merged 20 commits into from
Oct 20, 2020

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Sep 23, 2020 •
edited
Loading

Base support for GstMeta and mappings for GstVideoTimeCodeMeta.

Integrating and adapting code from PR #205 authored by Petr Lastovka.

@neilcsmith-net neilcsmith-net added this to the 1.3 milestone Sep 23, 2020
@neilcsmith-net
Copy link
Member Author

neilcsmith-net commented Sep 23, 2020 •
edited
Loading

  • Move contents of meta package to main packages, except for VideoTimeCodeMeta.
  • Move VideoTimeCodeMeta and contents of timecode package to video package.
  • Meta should be a NativeObject subclass.
  • Remove all lowlevel types from API.
  • Add GstMetaPtr typed pointer with ability to extract GType.
  • Work out better class to GType lookup for registered types? Or other way to get GType to pass to native layer.
  • Fix tests - all skipped because right version not initialized!

Above marries up better with upstream layout and Rust / C# bindings.

@neilcsmith-net
Copy link
Member Author

Related conversation on GStreamer devel about type relationships / other bindings - https://lists.freedesktop.org/archives/gstreamer-devel/2020-October/076302.html

@neilcsmith-net
Refactor to match upstream structure, and maintain separation between…
d0fa8ff 
… public and lowlevel API.

Move Meta to org.freedesktop.gstreamer, and add Meta.API type for mapping API GType / querying buffer.
Remove MetaInfo wrapper.
Add GstMetaPtr for use in lowlevel bindings.
Move VideoTimeCodeMeta and related classes to video package, matching upstream structure.
@neilcsmith-net
Copy link
Member Author

Hi @aveco-devel can you take a look at this, give your thoughts, and see if it still covers all you need it to? I'll look to merge this functionality into master soon, then look at mapping some of the other meta types. Thanks!

@neilcsmith-net neilcsmith-net mentioned this pull request Oct 15, 2020
Closed
@neilcsmith-net neilcsmith-net changed the title Merge meta to master Support for GstMeta (partial) Oct 15, 2020
@neilcsmith-net neilcsmith-net merged commit 4f373ad into master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
1 participant
@neilcsmith-net