Add support for generic probes on Pad. #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woglinde
reviewed
Oct 30, 2020
|
Need to check / add in support for probe removal return value - must release Pad.PROBE implementation to allow it to be GC'd. Add tests for this too. Storing probes and IDs in a Map<PROBE, NativeLong> inside Pad might be a better idea than current behaviour. |
… tidy up tests and documentation.
|
@lafoletc I agree needs a Query test. However, porting allocation query test didn't seem to work correctly. I also need to look at fixing up ProbeTester, but only thing I seemed to get was a Caps query with that pipeline when running a query probe IIRC. Feel free to take a look if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generic probes on Pad, better matching upstream API. Fixes #189