Fix syntax error and update example on homepage #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.md
Outdated
| window.set_title("First GTK+ Program"); | ||
| window.set_border_width(10); |
There was a problem hiding this comment.
I'm not sure this line is very useful in this example. ;)
There was a problem hiding this comment.
Perhaps not but I was mostly just updating it to do what https://github.com/gtk-rs/examples/blob/master/src/bin/basic.rs does.
There was a problem hiding this comment.
The goal is to remain as small as possible in here to just let users see a sample. Please remove this line and then I merge.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried building the code on the homepage and ran into some issues. This PR updates the example code so that it compiles and runs.