Skip to content

feat: add tsx support #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

evenstensberg
Copy link

#95

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evenstensberg 🤗

Adding this into the middle of the array messes up the test harness. If this should (purposefully) be loaded before babel is attempted, can you please adjust the tests appropriately? This also needs tests 🙏

Copy link
Author

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated PTAL. The tests are passing for me (node v22.3.0)

@fregante
Copy link

fregante commented Apr 5, 2025

Would be good to see this merged 🙏 I bumped into this issue again.

@phated
Copy link
Member

phated commented Jun 1, 2025

It looks like tsx doesn't run in the entire support matrix so we'll need to add some code to skip it on old node. Non-LTS Node versions are planned to be dropped in the next major.

@privatenumber
Copy link

No need to wait on me but FYI Im working on latest Node support now and is almost complete.

Copy link
Author

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated is there anything in this PR you need me to do? I think the easiest way to implement the skip of a certain node version is to add a case in https://github.com/gulpjs/interpret/blob/master/test/index.js .

@phated
Copy link
Member

phated commented Jun 2, 2025

@evenstensberg either you can implement the skip or the PR will need to wait until I can find the time to do it. It's easier to find time to review a passing PR than writing/pushing the code myself.

@evenstensberg
Copy link
Author

@phated which node version are you using in development locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants