Skip to content

Corrects a typo in specifying arguments #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2018
Merged

Corrects a typo in specifying arguments #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ $image->save('image2.jpg');

```php
$image = new ImageResize('image.jpg');
$image->crop(200, 200, ImageResize::CROPCENTER);
$image->crop(200, 200, true, ImageResize::CROPCENTER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the explanation to explain this optional boolean argument functionality.

$image->save('image2.jpg');
```

Expand All @@ -154,15 +154,15 @@ For instance passing the crop mode `CROPTOP` will result as 100px taken off the

```php
$image = new ImageResize('image.jpg');
$image->crop(200, 200, ImageResize::CROPTOP);
$image->crop(200, 200, true, ImageResize::CROPTOP);
$image->save('image2.jpg');
```

On the contrary passing the crop mode `CROPBOTTOM` will result as 100px taken off the top leaving you with 200px × 200px.

```php
$image = new ImageResize('image.jpg');
$image->crop(200, 200, ImageResize::CROPBOTTOM);
$image->crop(200, 200, true, ImageResize::CROPBOTTOM);
$image->save('image2.jpg');
```

Expand Down