Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two most important issues affects projects using this library and also using phpstan. The error we get in our project is the following:
static
is not in a namespacePHPStan thinks that
\static
is a class in the root namespace. Its perfectly fine to use juststatic
instead.Wrong return type
This method actually returns floats too. Not too important, but good to know.
Wrong casing of functions
Not affecting anything, so can revert this change if you like.
These changes will also make php-image-resize pass the first level (0)