Skip to content

add gamma correct option #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 1, 2019
Merged

add gamma correct option #132

merged 4 commits into from
Jan 1, 2019

Conversation

lefuturiste
Copy link
Contributor

With a new option on the main class, we will able to tell if we want gamma correction.

When you use this library and rescale a image, the image's colors tends to not be keeped, this is caused by the image gamma correction applied before and after the proccessing.

With a new option on the main class, we will able to tell if we want gamma correction.

When you use this library and rescale a image, the image's colors tends to not be keeped, this is caused by the image gamma correction applied before and after the proccessing.
@coveralls
Copy link

coveralls commented Dec 31, 2018

Pull Request Test Coverage Report for Build 199

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 81.081%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ImageResize.php 4 6 66.67%
Totals Coverage Status
Change from base Build 196: -0.4%
Covered Lines: 240
Relevant Lines: 296

💛 - Coveralls

@adityapatadia
Copy link
Contributor

It's great addition but we should provide it as function rather than just putting a class variable.
Something like following would be great.

$image = new ImageResize('image.jpg');
$image->gamma(false);

Please also update readme file accordingly and I will merge this and release new version.

@lefuturiste
Copy link
Contributor Author

This is the new commits I done. Should I rename the class variable gamma_correct to gamma ?

@lefuturiste
Copy link
Contributor Author

Btw, Happy new year!

@adityapatadia adityapatadia merged commit 06339a9 into gumlet:master Jan 1, 2019
@adityapatadia
Copy link
Contributor

Thanks a lot for your efforts. Happy new year 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants