Java 12-17API additions #10106
Java 12-17API additions #10106
Conversation
.../test-super/com/google/gwt/dev/jjs/super/com/google/gwt/emultest/java12/lang/StringTest.java
Outdated
Show resolved
Hide resolved
user/test/com/google/gwt/emultest/java12/util/stream/CollectorsTest.java
Outdated
Show resolved
Hide resolved
.../com/google/gwt/dev/jjs/super/com/google/gwt/emultest/java12/util/stream/CollectorsTest.java
Outdated
Show resolved
Hide resolved
user/super/com/google/gwt/emul/java/util/stream/Collectors.java
Outdated
Show resolved
Hide resolved
.../com/google/gwt/dev/jjs/super/com/google/gwt/emultest/java12/util/stream/CollectorsTest.java
Outdated
Show resolved
Hide resolved
| assertEquals(3, hideFromCompiler("foo").transform(String::length)); | ||
| } | ||
|
|
||
| public void testIndent() { |
There was a problem hiding this comment.
please also include a set of these tests that does not do a hideFromCompiler, so we can make sure that if the compiler is able to constant-fold these method calls, that it does so correctly.
There was a problem hiding this comment.
I did not implement any tests without hideFromCompiler yet since I wasn't sure which methods need them. It seems that tests either hide all inputs from compiler (like the ones from https://github.com/gwtproject/gwt/pull/9975/files#diff-79013db0b72ddfb9522327d93e6c5804f44c160025590e971ddfc7fd4eb7c045R26 ) or hide nothing (https://github.com/zbynek/gwt/blob/f0c1486a46018aec9de93458136cfc161f569e81/user/test/com/google/gwt/emultest/java/lang/StringTest.java#L542 ). Also I'm not sure if it wouldn't be better to test the constant-folding optimization and verify that these are actually folded rather than make assertions where we don't know if we're testing folding or emulation.
Co-authored-by: Colin Alworth <[email protected]>
zbynek
force-pushed
the
java17-emul
branch
3 times, most recently
from
077dfea to
55d86e0
Compare
zbynek
force-pushed
the
java17-emul
branch
4 times, most recently
from
033deb4 to
b6adb5d
Compare
zbynek
force-pushed
the
java17-emul
branch
6 times, most recently
from
0257e71 to
b8996b5
Compare
zbynek
force-pushed
the
java17-emul
branch
2 times, most recently
from
3f189f4 to
ec661eb
Compare
Fixes #9872
Fixes #10091
Fixes #9991