Skip to content

Style imports and pragmas with stylish-haskell #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Mar 1, 2022

No description provided.

@sjakobi
Copy link
Member Author

sjakobi commented Mar 1, 2022

I will finish this after merging #355.

@sjakobi sjakobi force-pushed the sjakobi/stylish-haskell branch from c5967fb to 70772f1 Compare March 2, 2022 21:05
@sjakobi sjakobi force-pushed the sjakobi/stylish-haskell branch 2 times, most recently from b135447 to 6ded61b Compare March 2, 2022 22:33
Also tweak some module abbreviations
@sjakobi sjakobi force-pushed the sjakobi/stylish-haskell branch from 6ded61b to d32e056 Compare March 2, 2022 22:40
@sjakobi sjakobi marked this pull request as ready for review March 2, 2022 22:40
@sjakobi
Copy link
Member Author

sjakobi commented Mar 2, 2022

@treeowl How do you feel about this?

My main motivation was that some import sections felt pretty messy and hard to navigate. I also felt the need to improve some module abbreviations and remove open imports.

I don't really plan on enforcing this style, but it should be easy to clean up future messes by simply running stylish-haskell with the config in .stylish-haskell.yaml.

sjakobi added 3 commits March 3, 2022 16:55
Previously stylish-haskell would fail to parse the
tests/Properties/HashMapLazy.hs file.
@sjakobi sjakobi merged commit 42a25db into master Mar 4, 2022
@sjakobi sjakobi deleted the sjakobi/stylish-haskell branch March 4, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant