Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Bump resolvers #1757

Merged
merged 3 commits into from
May 2, 2020
Merged

Bump resolvers #1757

merged 3 commits into from
May 2, 2020

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented May 2, 2020

cabal to 2020-05-02T10:11:15Z
stack-8.8.3 to lts-15.10
stack to nightly-2020-05-01

cabal to 2020-05-02T10:11:15Z
stack-8.8.3 to lts-15.10
stack to nightly-2020-05-01
@alanz alanz requested review from jneira and fendor May 2, 2020 13:13
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alanz
Copy link
Collaborator Author

alanz commented May 2, 2020

@jneira please give an opinion as to what test failures can be ignored.

@jneira
Copy link
Member

jneira commented May 2, 2020

jumm i think we have to take care of this one:

src/Haskell/Ide/Engine/Plugin/Ormolu.hs:73:46: error:
    • Couldn't match type ‘Bool’ with ‘RegionIndices’
      Expected type: Config RegionIndices
        Actual type: Config Bool
    • In the first argument of ‘ormolu’, namely ‘(conf o)’
      In the expression: ormolu (conf o) fp
      In the second argument of ‘try’, namely
        ‘(ormolu (conf o) fp $ T.unpack cont)’
   |
73 |       liftIO $ try @OrmoluException (ormolu (conf o) fp $ T.unpack cont)
   |                                              ^^^^^^
cabal: Failed to build haskell-ide-engine-1.3 (which is required by
exe:hie-wrapper from haskell-ide-engine-1.3, lib:hie-test-utils from
haskell-ide-engine-1.3 and others).

It is thrown for cabal jobs with ghc-8.8.3 and ghc-8.8.2

@alanz
Copy link
Collaborator Author

alanz commented May 2, 2020

Weird that it builds fine with 8.8.3 and ormolu-0.0.3.1for stack. Investigating, can repeat it with my machine.

@fendor
Copy link
Collaborator

fendor commented May 2, 2020

We have to limit the acceptable ormolu version
New release 0.5.0.0 is incompatible with HIE.
EDIT: latest commit fixes it, thank you!

@alanz
Copy link
Collaborator Author

alanz commented May 2, 2020

Green on circleCI. Ok to merge?

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual errors are the usual ones so it could be merged

@alanz alanz merged commit 38c6ca6 into haskell:master May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants