2.10.0.0: Wrong binaries

[kwj]

It seems to be failing to generate binary assets that contain a dot in the OS name.

For example, it looks like that two binary files for x86_64 Ubuntu 20.04. One has timestamps of last November, and the supporting GHC versions appear to be from that time. The another one which OS name without a dot seems to be the release file it should be this time.

$ ls
SHA1SUMS  haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz  haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz
$ sha1sum --check --ignore-missing SHA1SUMS
./haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz: OK
./haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz: OK
$ tar -tJv --wildcards -f haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz '*.in'
-rwxr-xr-x root/root      8573 2024-11-12 01:39 haskell-language-server-2.10.0.0/haskell-language-server-9.4.8.in
-rwxr-xr-x root/root      8591 2024-11-12 01:38 haskell-language-server-2.10.0.0/haskell-language-server-9.6.6.in
-rwxr-xr-x root/root      8607 2024-11-12 01:38 haskell-language-server-2.10.0.0/haskell-language-server-9.8.2.in
-rwxr-xr-x root/root      8988 2024-11-12 01:39 haskell-language-server-2.10.0.0/haskell-language-server-9.10.1.in
$ tar -tJv --wildcards -f haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz '*.in'
-rwxr-xr-x root/root      9197 2025-03-27 03:51 haskell-language-server-2.10.0.0/haskell-language-server-9.12.2.in
-rwxr-xr-x root/root      8573 2025-03-27 03:50 haskell-language-server-2.10.0.0/haskell-language-server-9.4.8.in
-rwxr-xr-x root/root      8988 2025-03-27 03:52 haskell-language-server-2.10.0.0/haskell-language-server-9.10.1.in
-rwxr-xr-x root/root      8591 2025-03-27 03:49 haskell-language-server-2.10.0.0/haskell-language-server-9.6.7.in
-rwxr-xr-x root/root      8607 2025-03-27 03:48 haskell-language-server-2.10.0.0/haskell-language-server-9.8.4.in
$ 

There were other similar binaries.

[fendor]

Hi, thank you for your bug report!

This seems to be a remnant from previous release attempts. Apparently, old CI runs produced binaries which we accidentally picked up and uploaded.

[fendor]

This seems also to be reflected in ghcup-metadata ghcup-vanilla-0.0.9.yaml. Affected release binaries are:

• haskell-language-server-2.10.0.0-aarch64-linux-ubuntu20.tar.xz
• haskell-language-server-2.10.0.0-x86_64-linux-mint19.3.tar.xz
• haskell-language-server-2.10.0.0-x86_64-linux-mint20.2.tar.xz
• haskell-language-server-2.10.0.0-x86_64-linux-ubuntu18.04.tar.xz
• haskell-language-server-2.10.0.0-x86_64-linux-ubuntu20.04.tar.xz
• haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz

These binaries are functional, but based on much older commits.

[fendor]

cc @wz1000, @michaelpj

[fendor]

@hasufell What's the best way to rectify this issue in ghcup-metadata? The binaries can be trusted and work, but have different bug-fixes depending on the platform.
Do we have to live with my mistake until the next release or can we update the ghcup-vanilla-*.yaml files?

[hasufell]

Do we have to live with my mistake until the next release or can be update the ghcup-vanilla-*.yaml files?

You have to force the user to reinstall. Due to the lack of revisions, that means the only way is to publish new metadata as 2.10.0.0-p1 and print a post-install message that it supercedes 2.10.0.0.

[fendor]

To avoid confusion, it might be better to cut a 2.10.0.1 release then?

[hasufell]

To avoid confusion, it might be better to cut a 2.10.0.1 release then?

I don't know. 2.10.0.0 is not in the main channel yet.

[fendor]

haskell/ghcup-metadata#297 adds a release 2.10.0.0-p1 which fixes the ghcup-metadata.

Regarding the URLs, it seems like from now on, it would be best to change the name of binaries from:

./haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz:

to

./haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz:

for all platforms whose version string contains a ..

@kwj Would that fix the issue for you?

[kwj]

I think this method is fine. However, in your pull request haskell/ghcup-metadata#297, hash values don't appear to be updated. Is this correct?

$ fgrep -A 2 -e 'haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz' ghcup-vanilla-0.0.9.yaml
              dlUri: https://downloads.haskell.org/~hls/haskell-language-server-2.10.0.0/haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz
              dlSubdir: haskell-language-server-2.10.0.0
              dlHash: f3de2609c3d6e1c188868f3946c61fbd3a764ad323b71fdd5ae139931c6c1cbc
$ fgrep -A 2 -e 'haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz' ghcup-vanilla-0.0.9.yaml
              dlUri: https://downloads.haskell.org/~hls/haskell-language-server-2.10.0.0/haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz
              dlSubdir: haskell-language-server-2.10.0.0
              dlHash: f3de2609c3d6e1c188868f3946c61fbd3a764ad323b71fdd5ae139931c6c1cbc
$ 
$ sha256sum haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22*
f3de2609c3d6e1c188868f3946c61fbd3a764ad323b71fdd5ae139931c6c1cbc  haskell-language-server-2.10.0.0-x86_64-linux-ubuntu22.04.tar.xz
e0d9051d984283f64866de8bd822ad64b22618f3360f87e9773225f0f49ec9cc  haskell-language-server-2.10.0.0-x86_64-linux-ubuntu2204.tar.xz

[fendor]

No, it is not :) Thanks again for noticing it! This mistake at least would have been detected by the ghcup-metadata release CI :)

Updated the PRs