Skip to content

Remove allow-newer for hiedb #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2025
Merged

Remove allow-newer for hiedb #4551

merged 5 commits into from
Apr 8, 2025

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Apr 8, 2025

Using GHC 9.12 compatible version of hiedb released yesterday.

@@ -77,4 +77,4 @@ workflows:
multiple-ghcs:
jobs:
- stackage-lts22
- stackage-nightly
- stackage-lts23
Copy link
Collaborator Author

@jhrcek jhrcek Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current stackage nightly is using ghc-9.10.1.

So I renamed the job to lts-23 (based on ghc-8.10.4) to reflect reality of the current stack.yaml.
But now repo settings is expecting stackage-nightly job that doesn't exist.

To fix this we can:

  • bump nightly resolver to use ghc 9.10 (more work - I would prefer not doing that in this PR)
  • change repo settings not to expect stackage-nightly job as mandatory, but to expect stackage-lts23 (but I don't have permissions to fix repo settings)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the repo settings

@jhrcek jhrcek marked this pull request as ready for review April 8, 2025 07:36
@jhrcek jhrcek requested review from michaelpj and wz1000 as code owners April 8, 2025 07:36
@michaelpj
Copy link
Collaborator

I've just removed the stackage-nightly required check for now.

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Apr 8, 2025
@mergify mergify bot merged commit 9474e78 into master Apr 8, 2025
37 checks passed
@michaelpj
Copy link
Collaborator

Apparently mergify can't update it because it conflicts with master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants