Fix completion for record dot syntax when record isn't known #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Jun 7, 2025
| @@ -912,7 +912,7 @@ getCompletionPrefixFromRope pos@(Position l c) ropetext = | |||
| [] -> Nothing | |||
| (x:xs) -> do | |||
| let modParts = reverse $ filter (not .T.null) xs | |||
| modName = T.intercalate "." modParts | |||
| modName = if all (isUpper . T.head) modParts then T.intercalate "." modParts else "" | |||
There was a problem hiding this comment.
Can you include some explanation for why this is the right thing to do? You explain it nicely in the PR description but it'll get lost if we don't write it in!
There was a problem hiding this comment.
Ah yes of course, will do!
Currently fighting CI 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the prefix info extractor didn't check that the "modName" it pulls out is a valid module name, so would include cases when using record dot syntax.
This is only an issue when the record type beforehand's type isn't known , i.e.
undefined.myField, as otherwise the incorrect completions were replaced with the field names directly.Fixes #4405