Change tracking of file types to language kinds #4621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryMilkyJoe
force-pushed
the
track-language-id
branch
2 times, most recently
from
9af92cf to
7d87e3f
Compare
VeryMilkyJoe
force-pushed
the
track-language-id
branch
4 times, most recently
from
ea2f6eb to
252e67f
Compare
The plugin descriptor now tracks the language kinds it is responsible for instead of the file endings. We get the language kinds of any file from the VFS. Currently we are using a source repository to be able to use the lsp changes needed, but once lsp is released this can be removed.
VeryMilkyJoe
force-pushed
the
track-language-id
branch
from
252e67f to
c083f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin descriptor now tracks the language kinds it is responsible for instead of the file endings.
This will allow files without ".hs" or other relevant file endings to still be handled by HLS if their language kind is set properly.
We get the language kinds of any file from the VFS.
Currently we are using a source repository to be able to use the lsp changes needed, but once lsp is released this can be removed.
Closes #3567