Check string-match argument type in haskell-do-try-info and haskell-do-try-type
#602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `haskell-do-try-info` and `haskell-do-try-type`, there is code of the form `(string-match "^[A-Za-z_]" (cdr state))` that didn't check `(stringp (cdr state))`.
|
@gracjan: Oops, sorry I missed that. (And deviant-logic balanced their parentheses correctly the first time!) Yes, it's the same bugfix, just in two functions and with a more localized check. I can take a look, although deep elisp hackery isn't my strong suit. |
This was referenced Apr 25, 2015
antalsz
referenced
this pull request
in antalsz/haskell-mode
Apr 25, 2015
The documentation mandates that `haskell-ident-at-point` return nil when there is no identifier at point; however, apparently, it instead returned `""` in that case at some point, and so some code made faulty assumptions based on that.
|
If I understand correctly this was subsumed by #603, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
haskell-do-try-infoandhaskell-do-try-type, there is code of the form(string-match "^[A-Za-z_]" (cdr state))that didn't check(stringp (cdr state)). This messed up my Emacs's connection to the*haskell*buffer when hitting space would sometimes cause an error. Checking thatstring-matchcan apply to(cdr state)seems to have fixed this, though.