Skip to content

Add github repo link in footer #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2021
Merged

Add github repo link in footer #109

merged 5 commits into from
Aug 26, 2021

Conversation

myShoggoth
Copy link
Contributor

Close #89

@tomjaguarpaw
Copy link
Contributor

How about replacing "here" with "at GitHub" and linking the whole sentence? For comparison

Personally, I find that link text which actually describes what it links to imposes a much lower cognitive load.

@goldfirere
Copy link
Contributor

goldfirere commented Aug 13, 2021

I've been taught that using "here" as link text is also poor for visually impaired users who might use a screen reader. See these guidelines on accessibility, for example.

Copy link
Contributor

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myShoggoth myShoggoth merged commit 7142590 into master Aug 26, 2021
@myShoggoth myShoggoth deleted the bug-reports branch August 26, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to this repo from the website
4 participants