feat: support human readable timestamps #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmastech
commented
Nov 6, 2023
hedhyw
reviewed
Nov 6, 2023
Co-authored-by: Maksym Kryvchun <[email protected]>
|
@hedhyw This is my first major contribution to anything in Golang. I hope that I didn't make too much of a mess of anything (especially the tests!). Look forward to your review notes 🙏 |
|
cosmastech
changed the title
|
one more thing there is a test example
|
cosmastech
force-pushed
the
issue/36-support-human-readable-timestamps
branch
from
aef6496 to
b4cf45b
Compare
|
Thanks @hedhyw! Ready for a final pass. |
hedhyw
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #36
This is my first time working on anything in Go, so I would appreciate any pointers. Thanks for the opportunity to work on this!