Skip to content

#125 - Consolidate SourceModelContext and SourceModelBuildingContext #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

sebersole
Copy link
Member

@sebersole sebersole commented Apr 14, 2025

Consolidated SourceModelContext and SourceModelBuildingContext and renamed ModelsContext.

Addresses #125

@sebersole
Copy link
Member Author

sebersole commented Apr 16, 2025

@marko-bekhta Would you mind taking a look at this and let me know how much of an impact it would have on Search?

I'd like to get this into 7.0 CR1, but I realize it is pretty disruptive and I don't want to cause you a lot of work.

Thanks!

sebersole added a commit to sebersole/hibernate-orm that referenced this pull request Apr 16, 2025
See hibernate/hibernate-models#127

DO NOT MERGE THIS - with the mavenLocal bits in settings.gradle!
@sebersole
Copy link
Member Author

You can see the impact in ORM itself at hibernate/hibernate-orm#10035

@marko-bekhta
Copy link
Member

it seems it's just a few files to update. I've got a patch ready, so it should not be a problem for Search. Also built this and ORM and tested with Search:

[INFO] Hibernate Search ITs - POJO Mapper Base ............ SUCCESS [ 22.464 s]
[INFO] Hibernate Search ITs - ORM ......................... SUCCESS [01:37 min]
[INFO] Hibernate Search ITs - ORM - Coordination - Outbox Polling SUCCESS [02:32 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

btw while building your ORM patch, Envers was complaining 😖 🙈 so here's a patch if you'd want: sebersole/hibernate-orm#231

@sebersole
Copy link
Member Author

Thank you @marko-bekhta !!!

@sebersole sebersole added this to the 1.0.0.CR1 milestone Apr 16, 2025
@sebersole sebersole merged commit ca8245a into hibernate:main Apr 16, 2025
4 checks passed
@sebersole sebersole deleted the ModelsContext branch April 16, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants