Throw an exception if query doesn't have a result but we expect one #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2883061.
…ults It should get thrown when a user call `.getSingleResultOrNull()` but the SQL query doesn't return any result. For example, when creating a stored procedure in PosgtreSQL
When running a native query that doesn't return any result (for example, the creation of a stored procedure), `io.vertx.sqlclient.SqlResult#columnsNames` will be null. This commit doesn two things: 1. add null check to avoid a NPE if `.columnsNames` returns null; 2. Throw an HibernateException if the user call getSingleResultOrNull but the query doesn't return any result. Note that we could return null in this situation, but we've decided to be consistent with Hibernate ORM, where the JDBC driver will throw the following exception (with PostgreSQL at least): ``` Caused by: org.postgresql.util.PSQLException: No results were returned by the query. at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:135) at org.hibernate.sql.results.jdbc.internal.DeferredResultSetAccess.executeQuery(DeferredResultSetAccess.java:240) ```
We are checking that it doesn't throw a NullPointerException if the result of the query doesn't have any columns names.
DavideD
force-pushed
the
1792-executeUpdate
branch
from
b183cdc to
773dc29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1792