fix a bug in merge() #954
Merged
fix a bug in merge() #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when replace() needs to load an association, do it reactively
Merged
Sanne
pushed a commit
to hibernate/hibernate-orm
that referenced
this pull request
Sep 7, 2021
|
@gavinking not sure I understand what's missing to close this issue |
|
I meant to comment on this issue: #959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #951
Well, it fixes one overloaded version of
DefaultReactiveMergeEventListener.copyValues(), which was enough to make the given test pass. I'm not sure if the same change needs to be made to the other one.