Reactivate CI regression tests for Windows + improve CI #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarzec
commented
Jun 17, 2024
| "$patch_file" | ||
| "$patch_file" \ | ||
| --ignore-cr-at-eol \ | ||
| --ignore-matching-lines="C:\\\\" |
There was a problem hiding this comment.
[Explanation] This option is excluding lines with Windows paths. On the GitHub runners those paths may include characters that seem to cause trouble with git diff.
This is hopefully a temporary solution.
jarzec
commented
Jun 17, 2024
| pure2-assert-expected-not-null.cpp2(14): error C3861: 'unexpected': identifier not found | ||
| predefined C++ types (compiler internal)(347): note: see declaration of 'std' | ||
| pure2-assert-expected-not-null.cpp2(14): error C2660: 'unexpected': function does not take 1 arguments | ||
| C:\Program Files\Microsoft Visual Studio�2nterprise\VC\Tools\MSVC .40.33807\includeh.h(33): note: see declaration of 'unexpected' |
There was a problem hiding this comment.
[Explanation] This path was always indicated as different despite the test file being updated. My conjecture is that this is due to the strange characters in the path.
jarzec
commented
Jun 17, 2024
| @@ -92,7 +92,7 @@ jobs: | |||
| bash run-tests.sh -c ${{ matrix.compiler }} -s ${{ matrix.cxx_std }} -d ${{ matrix.stdlib }} -l ${{ matrix.os }} | |||
|
|
|||
| - name: Run regression tests - Windows version | |||
| if: matrix.os == 'windows-latest' | |||
| if: startsWith(matrix.os, 'windows') | |||
There was a problem hiding this comment.
[Explanation] This line was not updated in a change of this workflow. I've noticed that somewhat accidentally looking at a change that should have caused the test run to fail (e.g. in here) while in fact it showed as successful.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression-tests/test-results/msvc-2022-c++20/pure2-assert-expected-not-null.cpp.outputafter the inclusion of..for non-UFCS,mixed-default-arguments.cpp2after the default initialization of function arguments.C:\from git diff. The reason is that on the GitHub runners the MSVC paths include strange characters that causegit diffto spuriously flag differences. I will raise an issue with with the GitHub team responsible for the Windows runners.