[FIX] is() function to handle polymorphic sidecast #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is not handling sidecasts.
The code:
returns
false
- the current implementation ofis()
function is usingstd::is_base_of
that blocks usingdynamic_cast
for sidecast.The current fix removes the requirement forThe current fix add a check if we are dealing with polymorpic types - if yes then theB2
being a base forB1
.dynamic_cast
is called.This PR close
is()
part of the #127as()
will be fixed after finalizing discussion here: #106 (it requires handling case whendynamic_cast
will returnnullptr
or throwbad_cast
).