Correct includes in cpp2util.h for MacOSX12.3 SDK #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOSX 12.3 SDK there is no <memory_resource> header there is <experimental/memory_resource> - check with __has_include to include existing one. There was no <cuchar> and <stop_token> - add checking if it is present.
filipsajdak
force-pushed
the
fsajdak-fix-macos-sdk-cpp2util-inlcludes
branch
from
91e6916 to
12e0d23
Compare
alexreinking
approved these changes
Sep 27, 2022
|
Thanks! I committed a change that adds three of the four requested feature test guards, but didn't add the fallback to |
Azmah-Bad
pushed a commit
to Azmah-Bad/cppfront
that referenced
this pull request
Feb 24, 2023
Azmah-Bad
pushed a commit
to Azmah-Bad/cppfront
that referenced
this pull request
Feb 24, 2023
I was trying to rely on only the named feature tests, but if adding this `__has_include` can unblock someone then let's do it. Also add a `(void)` cast to `~c_raii()` to silence a Clang warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOSX 12.3 SDK there is no
<memory_resource>header there is<experimental/memory_resource>- check with __has_include to include existing one.There was no
<cuchar>and<stop_token>- add checking if it is present.This PR was previously: #12