Skip to content

Consolidate grammar comments with parser logic. #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Consolidate grammar comments with parser logic. #195

merged 2 commits into from
Jan 5, 2023

Conversation

jbatez
Copy link
Contributor

@jbatez jbatez commented Jan 3, 2023

And remove some unnecessary cases already handled as unqualified-ids.

And remove some unnecessary cases already handled as unqualified-ids.
@hsutter
Copy link
Owner

hsutter commented Jan 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to cppfront. Before I can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). You should find it in your email soon, if not let me know if you need me to resend it.

@jbatez
Copy link
Contributor Author

jbatez commented Jan 5, 2023

Done! Also fixed some merge conflicts that arose since the PR was created.

@hsutter hsutter merged commit f3cb627 into hsutter:main Jan 5, 2023
Azmah-Bad pushed a commit to Azmah-Bad/cppfront that referenced this pull request Feb 24, 2023
Consolidate grammar comments with parser logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants