Skip to content

No code changes, just fixes to function comment blocks #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

gregmarr
Copy link
Contributor

@gregmarr gregmarr commented Jan 7, 2023

One block was on the wrong function, moved it to the right place, then added a new block on that function with a potential description. Another function had a copy of a different function's block, updated to the right function name and a potential description.

You should have my email address if you need a signoff.

Signed-off-by: gregmarr [email protected]

One block was on the wrong function, moved it to the right place, then added a new block on that function with a potential description.
Another function had a copy of a different function's block, updated to the right function name and a potential description.

Signed-off-by: gregmarr <[email protected]>
@hsutter
Copy link
Owner

hsutter commented Jan 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to cppfront. Before I can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). You should receive one in your email soon, if not please let me know and we can try again.

@hsutter hsutter self-requested a review January 7, 2023 22:02
@hsutter
Copy link
Owner

hsutter commented Jan 9, 2023

Looks good, thanks!

@hsutter hsutter merged commit 48da7e2 into hsutter:main Jan 9, 2023
Azmah-Bad pushed a commit to Azmah-Bad/cppfront that referenced this pull request Feb 24, 2023
One block was on the wrong function, moved it to the right place, then added a new block on that function with a potential description.
Another function had a copy of a different function's block, updated to the right function name and a potential description.

Signed-off-by: gregmarr <[email protected]>

Signed-off-by: gregmarr <[email protected]>
@gregmarr gregmarr deleted the patch-1 branch June 2, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants