Skip to content

Fix duplicate symbol cpp2::Uncaught_exceptions() #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

filipsajdak
Copy link
Contributor

5575ec4 added new symbols to cpp2util.h that caused the linker to find a duplicate symbol of cpp2::Uncaught_exceptions().

Linking multiple cpp2 files ends with:

[build] duplicate symbol 'cpp2::Uncaught_exceptions()' in:
[build]     libs/execspec/CMakeFiles/libexecspec.dir/src/application.cpp.o
[build]     libs/markdown/CMakeFiles/libmarkdown.dir/src/markdown.cpp.o
[build] duplicate symbol 'cpp2::Uncaught_exceptions()' in:
[build]     libs/execspec/CMakeFiles/libexecspec.dir/src/application.cpp.o
[build]     libs/execspec/CMakeFiles/libexecspec.dir/src/compile_cpp2.cpp.o
[build] duplicate symbol 'cpp2::Uncaught_exceptions()' in:
[build]     libs/execspec/CMakeFiles/libexecspec.dir/src/application.cpp.o
[build]     apps/execspec/CMakeFiles/execspec.dir/src/main.cpp.o
[build] ld: 3 duplicate symbols for architecture arm64

This change adds inline to cpp2::Uncaught_exceptions() function that fixes an error.

prenaux added a commit to prenaux/cppfront that referenced this pull request Jan 11, 2023
prenaux added a commit to prenaux/cppfront that referenced this pull request Jan 11, 2023
@hsutter
Copy link
Owner

hsutter commented Jan 11, 2023

Thanks!

@hsutter hsutter merged commit 06730e3 into hsutter:main Jan 11, 2023
@filipsajdak filipsajdak deleted the fsajdak-fix-duplicated-symbol-uncaught_exceptions branch January 12, 2023 21:19
Azmah-Bad pushed a commit to Azmah-Bad/cppfront that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants