cpp2util.h: Fix typeid(T) -> Typeid<T> usage with -fno-rtti. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prenaux
force-pushed
the
pierre-fix-no-rtti-compilation-issue
branch
from
5127dd3 to
2d49a07
Compare
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no exception / no rtti modes seem to be working fine. Just this small fix needed.
Side note: I ended up defining CPP2_NO_EXCEPTIONS & CPP2_NO_RTTI in my build system. I did look at adding a preprocessor based auto-detection in cpp2util.h but it turns out that its compiler dependant so its a whole mess to do robustly, and it seems out of scope at least for now.