Fix removing parens for in-place objects - quick fix of #331 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsajdak
force-pushed
the
fsajdak-quick-fix-of-331
branch
from
32e314d to
85403bc
Compare
That should cover cases:
```cpp
f1(:std::vector=(1,2,3));
f2(:std::vector=(1,2,3),:std::vector=(4,5));
ar[:index=(1,2)];
ar2[:index=(1,2), :index=(2,1)];
```
that will generate:
```cpp
f1(std::vector{1, 2, 3});
f2(std::vector{1, 2, 3}, std::vector{4, 5});
cpp2::assert_in_bounds(ar, index{1, 2});
cpp2::assert_in_bounds(ar2, index{1, 2}, index{2, 1});
```
filipsajdak
force-pushed
the
fsajdak-quick-fix-of-331
branch
from
85403bc to
d3fda5a
Compare
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
That should cover cases:
```cpp
f1(:std::vector=(1,2,3));
f2(:std::vector=(1,2,3),:std::vector=(4,5));
ar[:index=(1,2)];
ar2[:index=(1,2), :index=(2,1)];
```
that will generate:
```cpp
f1(std::vector{1, 2, 3});
f2(std::vector{1, 2, 3}, std::vector{4, 5});
cpp2::assert_in_bounds(ar, index{1, 2});
cpp2::assert_in_bounds(ar2, index{1, 2}, index{2, 1});
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should cover cases:
that will generate: